On Wed, Mar 22, 2017 at 11:34 AM, Flávio J. Saraiva <flaviojs2005(a)gmail.com> wrote:
Hi,
Some time ago I was told that every patch in a patch set all patches should produce a state that passes all the tests. Given how much the current code is interconnected, i don't think i can split this while keeping the tests functional.
How should I proceed in this case, can I split the code into logical bits knowing that the intermediate states will not pass the tests?
Flávio J. Saraiva
You could start by submitting test-only patches first, demonstrating the issues. Then, split the code. For instance, your patch says "Adjust CMD_LIST to a tree-like structure and implement command chainsAdjust CMD_LIST to a tree-like structure and implement command chains", maybe the structure change could be a single patch, ensuring tests still pass? Then add one or more patches fixing the tests. Just my 2 ¢ -- Frédéric Delanoy
2017-03-21 21:06 GMT+00:00 Marvin <testbot(a)winehq.org>:
Thank you for your contribution to Wine!
This is an automated notification to let you know that your patch has been reviewed and its status set to "Needs splitting".
This means that the patch needs to be split, either because it contains unrelated changes that should be their own separate patch, or because it's too large for review. You need to find a way to resend the changes in smaller chunks.
If you do not understand the reason for this status, disagree with our assessment, or are simply not sure how to proceed next, please ask for clarification by replying to this email.