On Jul 17, 2016, at 4:08 PM, Ken Thomases <ken@codeweavers.com> wrote:
>
> On Jul 16, 2016, at 3:15 AM, David Lawrie <david.dljunk@gmail.com> wrote:
>>
>> +static CFStringRef get_device_name(IOHIDDeviceRef device)
>> +{
>> +�� �� CFTypeRef ref;
>> +�� �� CFStringRef name = CFSTR("Default Name");
>
> You can probably do better for a fallback.�� For example, you can format the vendor ID and product ID into a string.�� For an extreme take on this, see the Copy_DeviceName() function in Apple's HID Calibrator sample code:
> https://developer.apple.com/library/mac/samplecode/HID_Calibrator/Listings/HID_Calibrator_IOHIDDeviceWindowCtrl_m.html

Oh, and for the case where device is NULL, it's fine to return NULL.�� It should never happen and, if it does, we want a crash to figure out why and fix things in a better manner, rather than papering over it with a bogus value.

-Ken