should I iterate over all possible values other than sizeof(MONITORINFO) and sizeof(MONITORINFOEXA) ? Kind Regards, Patrick Rudolph Originalnachricht Von: Alexandre Julliard Gesendet: Freitag, 18. April 2014 13:47 An: Patrick Rudolph Cc: wine-devel(a)winehq.org Betreff: Re: [PATCH 2/2] user32: add tests for valid cbSize in GetMonitorInfoA Patrick Rudolph <siro(a)das-labor.org> writes:
@@ -362,6 +363,21 @@ static void test_monitors(void) monitor = pMonitorFromRect( &rc, MONITOR_DEFAULTTONULL ); }
+ /* sanity check */ + monitor = pMonitorFromRect( &rc, MONITOR_DEFAULTTONEAREST ); + mi.cbSize = sizeof(mi); + ret = pGetMonitorInfoA( monitor, &mi ); + ok( ret, "GetMonitorInfo failed\n" ); + + miex.cbSize = sizeof(miex); + ret = pGetMonitorInfoA( monitor, (LPMONITORINFO)&miex ); + ok( ret, "GetMonitorInfo failed\n" ); + + /* specify invalid cbSize */ + mi.cbSize = 0xdeadbeef; + ret = pGetMonitorInfoA( monitor, &mi ); + ok( !ret, "GetMonitorInfo succeded\n" );
That's not a very convincing test. -- Alexandre Julliard julliard(a)winehq.org