Re: [PATCH v2 3/5] ddraw/tests: Test cursor clipping.

[Zhiyi Zhang]

On 4/8/20 10:30 PM, Henri Verbeet wrote:
> On Wed, 8 Apr 2020 at 14:31, Zhiyi Zhang <zzhang(a)codeweavers.com> wrote:
> > Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com>
> > ---
> >  dlls/ddraw/tests/ddraw7.c | 168 ++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 168 insertions(+)
>
> We can probably get rid of the existing cursor clipping tests from
> ddrawmodes.c as well. Do you have tests for the other ddraw versions
> as well?
> Do you want the tests for ddraw1, 2, 4 as well?
> > +    hr = IDirectDraw7_SetDisplayMode(ddraw, param.new_width, param.new_height,
> > +            registry_mode.dmBitsPerPel, 0, 0);
> > It probably doesn't make a difference here, but note that we have a
> > set_display_mode() helper.