Re: [PATCH vkd3d 2/3] vkd3d: Protect private data with mutex.

[Henri Verbeet]

On Wed, 9 Jan 2019 at 16:53, Józef Kucia <joseph.kucia(a)gmail.com> wrote:
> @@ -4934,7 +4953,11 @@ HRESULT d3d12_command_signature_create(struct d3d12_device *device, const D3D12_
>      memcpy((void *)object->desc.pArgumentDescs, desc->pArgumentDescs,
>              desc->NumArgumentDescs * sizeof(*desc->pArgumentDescs));
>
> -    vkd3d_private_store_init(&object->private_store);
> +    if (FAILED(hr = vkd3d_private_store_init(&object->private_store)))
> +    {
> +        vkd3d_free(object);
> +        return hr;
> +    }
> Does this leak "object->desc.pArgumentDescs" on failure?