Re: [PATCH] winedbg: gdb proxy mode: support qAttached packet

[Eric Pouech]

Paul Bolle a écrit :
> Add support for the qAttached packet. Main benefit is that if gdb was
> attached to a debuggee and it quits it will now ask if it should detach
> from the debuggee instead of asking whether the debuggee should be
> killed. (It still will ask whether the debuggee should be killed if it
> launched the debuggee itself).
>
> Signed-off-by: Paul Bolle <pebolle(a)tiscali.nl>
> ---
> Would it be better to add a new member to gdbctx instead of using a
> separate variable (qAttached_reply)?

yes, inclusion in gdbctx is preferred (and storage should rather be an 
integer rather than a string pointer)
A+

-- 
Eric Pouech
"The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)