Re: [PATCH v2 4/4] winegstreamer: Create static pads on wg_transform struct.

[Zebediah Figura]

On 2/14/22 04:19, Rémi Bernon wrote:
> @@ -63,7 +84,31 @@ NTSTATUS wg_transform_create(void *args)
>       if (!(transform = calloc(1, sizeof(*transform))))
>           return E_OUTOFMEMORY;
>
> +    src_caps = wg_format_to_caps(&input_format);
> +    assert(src_caps);
> +    sink_caps = wg_format_to_caps(&output_format);
> +    assert(sink_caps);
> +
> +    template = gst_pad_template_new("src", GST_PAD_SRC, GST_PAD_ALWAYS, src_caps);
> +    assert(template);
> +    transform->my_src = gst_pad_new_from_template(template, "src");
> +    g_object_unref(template);
> +    assert(transform->my_src);
> +
> +    template = gst_pad_template_new("sink", GST_PAD_SINK, GST_PAD_ALWAYS, sink_caps);
> +    assert(template);
> +    transform->my_sink = gst_pad_new_from_template(template, "sink");
> +    g_object_unref(template);
> +    assert(transform->my_sink);

Although I'd personally prefer to assert() the results of memory 
allocation, I suspect we don't want to do that in Wine.