Re: [PATCH 3/3] ddraw: Check for DDRAW_NO3D before checking for a video memory surface in d3d_device_create().

[Henri Verbeet]

On 28 September 2018 at 04:07, Mathew Hodson <mathew.hodson(a)gmail.com> wrote:
> On Thu, 27 Sep 2018 at 11:46, Henri Verbeet <hverbeet(a)codeweavers.com> wrote:
> > -        return DDERR_NO3D;
> > +        return DDERR_OUTOFMEMORY;
>
> Is it supposed to return out of memory when DDRAW_NO3D is set? I
> didn't get that from the commit message.

Yeah. The commit message didn't quite spell it out, but see e.g. [1] and [2].

[1] https://test.winehq.org/data/d8f3f1b71726b793f2f9a86225a73a7d286e62b3/win7_n...
[2] https://source.winehq.org/git/wine.git/blob/HEAD:/dlls/ddraw/tests/d3d.c#l15...