Re: [PATCH] ddraw/tests: Make test_depth_readback work on Nvidia GPUs on Windows.

[Stefan Dösinger]

On 19/01/18 03:24, Dmitry Timoshkov wrote:
> Stefan Dösinger <stefan(a)codeweavers.com> wrote:
> > +    if (broken(ddraw_is_nvidia(ddraw)))
> > +    {
> > +        /* ddraw1 only has access to D16 Z buffers (and D24 ones, which are even more
> > +         * broken on Nvidia), so don't even attempt to run this test on Nvidia cards
> > +         * because some of them have broken D16 readback. See the ddraw7 version of
> > +         * this test for a more detailed comment. */
> > +        skip("Some Nvidia GPUs have broken D16 readback, skipping.\n");
> > +        IDirectDraw_Release(ddraw);
> > +        DestroyWindow(window);
> > +        return;
> > +    }
> > broken() statement is redundant.
> > right, ddraw_is_vendor already takes care of this, I'll fix