Re: [PATCH 0/3] MR332: d3dx10: Support creating effect from pre-built shader

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx10_43/tests/d3dx10.c:
> +    /* test resource that doesn't exist */
>      hr = D3DX10CreateEffectFromResourceA(GetModuleHandleA(NULL), "resource", NULL, NULL, NULL,
>              "fx_4_0", 0, 0, device, NULL, NULL, &effect, NULL, NULL);
>      ok(hr == D3DX10_ERR_INVALID_DATA, "Unexpected hr %#x.\n", hr);
>
> +
> +    /* test creating effect from pre-built DXBC shader */
> +    errors = NULL;
> +    effect = NULL;
> +    hr = D3DX10CreateEffectFromResourceA(GetModuleHandleA(NULL), "fx_test_ecbt.fx", NULL,
> +            NULL, NULL, "fx_4_0", 0x0, 0x0, device, NULL, NULL, &effect,
> +            &errors, NULL);
> +    todo_wine ok(hr == S_OK, "D3DX10CreateEffectFromResource failed: %#x\n", hr);
> +    todo_wine ok(errors == NULL, "Got unexpected effect errors\n");
> +    todo_wine ok(effect != NULL, "No effect created\n");

For these we would usually do:
```suggestion:-1+0
    todo_wine ok(!errors, "Got unexpected errors %p.\n", errors);
    todo_wine ok(!!effect, "Got unexpected effect %p.\n", effect);
```

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/332#note_3144