Re: [PATCH 6/6] Implement SxsLookupClrGuid

[Nikolay Sivov]

On 8/7/2018 10:26 PM, Fabian Maurer wrote:
>  
> >
> > > + if
> > > (!FindActCtxSectionGuid(FIND_ACTCTX_SECTION_KEY_RETURN_HACTCTX, 0,
> > > ACTIVATION_CONTEXT_SECTION_COM_SERVER_REDIRECTION, pClsid,
> > > &guid_info)) +
> > > {
> > > + DWORD error = GetLastError();
> > > + if (error != ERROR_SXS_KEY_NOT_FOUND)
> > > + ERR("Failed to find guid: %d\n", error);
> > > + SetLastError(ERROR_NOT_FOUND);
> > > + return FALSE;
> > > + }
> >
> > This looks too complicated.
>
>  
>
> Just a bit or extra error checking in case something goes wrong, but I
> can throw that out if you want.

It depends on how it should work.