Re: d3dx9: Implementation of D3DXMatrixDecompose 2/2

[H. Verbeet]

2008/8/5 David Adam <david.adam.cnrs(a)gmail.com>:
> Hi,
>
> some remarks
>
> +    if (((*poutscale).x==0)||((*poutscale).y==0)||((*poutscale).z==0))
> should be
> +    if ((poutscale->x==0)||(poutscale->y==0)||(poutscale->z==0))

To add to that, you really should test your error paths in your test case.

Also:
> +    TRACE("\n");
> That's not a very informative TRACE.