Re: [PATCH 3/5] winegstreamer: Reject incompatible input media types in MPEG audio decoder.

[Zebediah Figura]

On 4/27/22 01:42, Anton Baskanov wrote:
> +    if (format->wfx.wFormatTag != WAVE_FORMAT_MPEG
> +            || sizeof(WAVEFORMATEX) + format->wfx.cbSize < sizeof(MPEG1WAVEFORMAT))
> +        return S_FALSE;

Not a big deal, but some manual testing implies that native doesn't 
actually check cbSize.
> +
> +    if ((format->fwHeadLayer & (ACM_MPEG_LAYER1 | ACM_MPEG_LAYER2)) != format->fwHeadLayer)
> +        return S_FALSE;

This doesn't read the most intuitively to me, and some manual testing 
implies that the condition actually checked here is

     if (format->fwHeadLayer == ACM_MPEG_LAYER3)