Re: [PATCH 4/4] vbscript: Implemented Abs(try 2)

[Jacek Caban]

On 06/17/14 08:00, Shuai Meng wrote:
> diff --git a/dlls/vbscript/global.c b/dlls/vbscript/global.c
> index d21784d..e646a29 100644
> --- a/dlls/vbscript/global.c
> +++ b/dlls/vbscript/global.c
> @@ -1302,8 +1302,24 @@ static HRESULT Global_ChrW(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARI
>
> static HRESULT Global_Abs(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res)
>  {
> -    FIXME("\n");
> -    return E_NOTIMPL;
> +    VARIANT v;
> +    HRESULT hres;
> +
> +    TRACE("(%s)\n", debugstr_variant(arg));
> +
> +    assert(args_cnt == 1);
> +
> +    V_VT(&v) = VT_EMPTY;
> +    hres = VariantChangeType(&v, arg, VARIANT_LOCALBOOL, VT_R8);
> +        if (FAILED(hres))
> +            return S_OK;

Please use to_double here. Also note weird indention here.

Jacek