Re: Patch 85420

[Marcus Meissner]

On Tue, Apr 17, 2012 at 09:10:45PM +0200, Christian Costa wrote:
> Hi,
>
> Patch http://source.winehq.org/patches/data/85420 is marked as
> pending. I've taken a look but I still don't understand what's
> wrong.
> Is there anything I've missed ?

I stopped reading at this line:

+        *frame = (LPDIRECT3DRMFRAME)(&impl_from_IDirect3DRMFrame3(This->parent)->IDirect3DRMFrame2_iface);

You are doing something very wrong if you need to cast this way.

It probably also needs explicit sign-off drom the d3d folks as it handles funny refcounting.

Ciao, Marcus