On Fri, Aug 28, 2015 at 8:30 PM, Henri Verbeet <hverbeet(a)gmail.com> wrote:
On 28 August 2015 at 05:46, Matt Durgavich <mattdurgavich(a)gmail.com> wrote:
+DECL_HANDLER(close_all_sockets) You'll want to just move this to sock.c and avoid making sock_ops available outside sock.c. You may want to change the request name to something along the lines of "close_process_sockets", since it only closes sockets for the current process, not all sockets the server knows about.
I think a better name would be winsock_cleanup or socket_cleanup because closing the sockets may not be the only action required to proper implement WSACleanup.
+ } + else + { + TRACE("pending cleanups: %d\n", num_startup); + }
Please just drop the else and let the message be printed so the amount of cleanups and starts is always displayed in the log.