Re: d3d [1]: Remove AddRef from IWineD3DDevice_GetVertexDeclaration.

[H. Verbeet]

On 22/11/06, Robert Shearman <rob(a)codeweavers.com> wrote:
> Markus Amsler wrote:
> > @@ -4704,7 +4704,6 @@ static HRESULT WINAPI IWineD3DDeviceImpl
> >      TRACE("(%p) : ppDecl=%p\n", This, ppDecl);
> >
> > *ppDecl = This->stateBlock->vertexDecl;
> > -    if (NULL != *ppDecl) IWineD3DVertexDeclaration_AddRef(*ppDecl);
> >      return WINED3D_OK;
>
> These patches violate COM rules. Is this for performance or other reasons?
> The plan seems to be to not use COM for wined3d anymore, mainly
> because the layering of d3d87/8/9 on top of wined3d is causing some
> problems with reference counts. Those could probably be solved by
> using eg aggregation, but I think the general feeling is that COM only
> makes things harder in wined3d.