Re: [PATCH 2/5] oleaut32/tests: Make tests working on older systems, prevent crash on some wine boxes

[Paul Vriens]

On 03/17/2010 10:05 PM, Piotr Caban wrote:
> hres = ICreateTypeInfo_AddRefTypeInfo(createti, unknown,&hreftype);
>       ok(hres == S_OK, "got %08x\n", hres);
> +    if(hres != S_OK) {
> +        skip("Skipping some tests\n");
> +        return;
> +    }

Hi Piotr,

If it's acceptable to get something else besides S_OK you should change 
the ok() and add a broken() (still bail out of course).

A skip() usually means that something valid happened and we need to bail 
out.

-- 
Cheers,

Paul.