Re: [PATCH 3/4] wined3d: Clip blits from / to the front buffer to the GL drawable.

[Henri Verbeet]

On 6 July 2015 at 23:47, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
> -void surface_translate_drawable_coords(const struct wined3d_surface *surface, HWND window, RECT *rect)
> +BOOL surface_clip_drawable_coords(const struct wined3d_surface *surface, HWND window,
> +        RECT *screen_rect, RECT *other)
> Can we please call these "src_rect" and "dst_rect" instead of
> "screen_rect" and "other"? It probably wouldn't hurt to mention "blt"
> somewhere in the function name either.
> +        ClientToScreen(window, &offset);
> ...
> -        ScreenToClient(window, &offset);
> -        OffsetRect(rect, offset.x, offset.y);
> +        /* Finally, translate the screen coordinate rectangle to client coordinates. */
> +        OffsetRect(screen_rect, -offset.x, -offset.y);
> That change seems pretty pointless.
> +BOOL wined3d_clip_blit(const RECT *clip_rect, RECT *clipped, RECT *other)
> "src_rect", "dst_rect".