Re: wineqtdecoder: properly clean up splitter and loader threads on QTSplitter destruction

[Alexandre Julliard]

Aric Stewart <aric(a)codeweavers.com> writes:
> @@ -495,9 +518,14 @@ static DWORD WINAPI QTSplitter_loading_thread(LPVOID data)
>              to try to minimize that.
>           */
>
> -        while(GetMovieLoadState(This->pQTMovie) < kMovieLoadStateComplete)
> +        while(This->pQTMovie && GetMovieLoadState(This->pQTMovie) < kMovieLoadStateComplete)
>          {
>              EnterCriticalSection(&This->csReceive);
> +            if (!This || !This->pQTMovie)
> +            {
> +                LeaveCriticalSection(&This->csReceive);
> +                return 0;
> +            }

This doesn't make sense. The this pointer cannot become NULL, and the
whole thing should most likely be inside the critical section.

-- 
Alexandre Julliard
julliard(a)winehq.org