Hi Huw, thanks for the quick review! Huw Davies <huw(a)codeweavers.com> wrote:
On Tue, Feb 22, 2022 at 01:02:33PM +0300, Dmitry Timoshkov wrote:
Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- programs/dllhost/dllhost.c | 217 ++++++++++++++++++++++++++++++++++++- 1 file changed, 213 insertions(+), 4 deletions(-)
This is generating a few -Wformat warnings:
In file included from programs/dllhost/dllhost.c:27: programs/dllhost/dllhost.c: In function ‘factory_AddRef’: programs/dllhost/dllhost.c:81:11: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 6 has type ‘ULONG’ {aka ‘long unsigned int’} [-Wformat=] 81 | TRACE("(%p)->%u\n", iface, ref); | ^~~~~~~~~~~~ ~~~ | | | ULONG {aka long unsigned int}
Apart from that, the series looks good at first glance.
I don't get the warnings with clang, will check with a gcc build. Should I resend with the warnings fixed, or should I wait for more comments? -- Dmitry.