Re: [PATCH 1/2] propsys: Implement VariantToStringWithDefault.

[Nikolay Sivov]

On 3/25/22 04:44, Mohamad Al-Jaf wrote:
> +/******************************************************************
> + *  VariantToStringWithDefault   (PROPSYS.@)
> + */
> +PCWSTR WINAPI VariantToStringWithDefault(const VARIANT *pvar, LPCWSTR pszDefault)
> +{
> +    TRACE("(%p, %s)\n", pvar, debugstr_w(pszDefault));
> +
> +    if (V_VT(pvar) == VT_BSTR)
> +    {
> +        if (V_BSTR(pvar) == NULL)
> +            return L"";
> +
> +        return V_BSTR(pvar);
> +    }
> +
> +    return pszDefault;
> +}
> This feels incomplete. There is at least a BYREF case, but also it's 
> possible to have a nested variant ref.