Re: [PATCH] taskmgr: Replace repeated assignments with for loops.

[Alexandre Julliard]

Isira Seneviratne <isirasen96(a)gmail.com> writes:
> @@ -317,31 +317,17 @@ void SaveColumnSettings(void)
>      TaskManagerSettings.Column_IOWriteBytes = FALSE;
>      TaskManagerSettings.Column_IOOther = FALSE;
>      TaskManagerSettings.Column_IOOtherBytes = FALSE;
> +
>      TaskManagerSettings.ColumnSizeArray[0] = 105;
>      TaskManagerSettings.ColumnSizeArray[1] = 50;
>      TaskManagerSettings.ColumnSizeArray[2] = 107;
> -    TaskManagerSettings.ColumnSizeArray[3] = 70;
>      TaskManagerSettings.ColumnSizeArray[4] = 35;
> -    TaskManagerSettings.ColumnSizeArray[5] = 70;
> -    TaskManagerSettings.ColumnSizeArray[6] = 70;
>      TaskManagerSettings.ColumnSizeArray[7] = 100;
> -    TaskManagerSettings.ColumnSizeArray[8] = 70;
> -    TaskManagerSettings.ColumnSizeArray[9] = 70;
> -    TaskManagerSettings.ColumnSizeArray[10] = 70;
> -    TaskManagerSettings.ColumnSizeArray[11] = 70;
> -    TaskManagerSettings.ColumnSizeArray[12] = 70;
> -    TaskManagerSettings.ColumnSizeArray[13] = 70;
> -    TaskManagerSettings.ColumnSizeArray[14] = 60;
> -    TaskManagerSettings.ColumnSizeArray[15] = 60;
> -    TaskManagerSettings.ColumnSizeArray[16] = 60;
> -    TaskManagerSettings.ColumnSizeArray[17] = 60;
> -    TaskManagerSettings.ColumnSizeArray[18] = 60;
> -    TaskManagerSettings.ColumnSizeArray[19] = 70;
> -    TaskManagerSettings.ColumnSizeArray[20] = 70;
> -    TaskManagerSettings.ColumnSizeArray[21] = 70;
> -    TaskManagerSettings.ColumnSizeArray[22] = 70;
> -    TaskManagerSettings.ColumnSizeArray[23] = 70;
> -    TaskManagerSettings.ColumnSizeArray[24] = 70;
> +    for (i=3; i<25; i++)
> +        if (i==3 || i==5 || i==6 || (i>=8 && i<=13) || i>=19)
> +            TaskManagerSettings.ColumnSizeArray[i] = 70;
> +        else if (i!=4 && i!=7)
> +            TaskManagerSettings.ColumnSizeArray[i] = 60;

That's not better. Instead, you should probably define a constant array
with these values.

-- 
Alexandre Julliard
julliard(a)winehq.org