Re: [PATCH v3 2/2] winex11drv: Add mutable pixel format awareness.

[Henri Verbeet]

On Fri, 16 Apr 2021 at 23:11, Connor McAdams <cmcadams(a)codeweavers.com> wrote:
> Add the ability to check if the pixel format was changed by wined3d, and
> if it was, allow the application to change it with a regular
> SetPixelFormat call.

"... was set by wglSetPixelFormatWINE()", technically.
> @@ -1461,7 +1466,7 @@ void sync_gl_drawable( HWND hwnd, BOOL known_child )
>          if (!known_child) break; /* Still a childless top-level window */
>          /* fall through */
>      case DC_GL_PIXMAP_WIN:
> -        if (!(new = create_gl_drawable( hwnd, old->format, known_child ))) break;
> +        if (!(new = create_gl_drawable( hwnd, old->format, known_child, FALSE ))) break;
>          mark_drawable_dirty( old, new );
>          XFlush( gdi_display );
>          TRACE( "Recreated GL drawable %lx to replace %lx\n", new->drawable, old->drawable );
> @@ -1498,7 +1503,7 @@ void set_gl_drawable_parent( HWND hwnd, HWND parent )
>          return;
>      }
>
> -    if ((new = create_gl_drawable( hwnd, old->format, FALSE )))
> +    if ((new = create_gl_drawable( hwnd, old->format, FALSE, FALSE )))
>      {
>          mark_drawable_dirty( old, new );
>          release_gl_drawable( new );
> Shouldn't those use "old->mutable_pf"?