2017-07-17 8:18 GMT-06:00 Piotr Caban <piotr.caban(a)gmail.com>:
Hi,
On 07/16/17 05:11, Alex Henrie wrote:
2017-07-14 4:20 GMT-06:00 Piotr Caban <piotr.caban(a)gmail.com>:
On 07/14/17 07:14, Alex Henrie wrote:
+/********************************************************************* + * log1pf (MSVCR120.@) + */ +float CDECL MSVCR120_log1pf(float x) +{ +#ifdef HAVE_LOG1PF + return log1pf(x); +#else + return log(1 + x); +#endif +}
Please also set errno in this function.
The Microsoft implementations of log2 and log1p are buggy: Despite what MSDN says, they do not set errno.
In fact, as far as I can tell, Microsoft's acosh, atanh, and expm1 don't set errno either. Do you want tests for this?
New versions are setting the errno. You can e.g. test it with ucrtbase.
I don't know what I was doing before. All of these functions first appeared in msvcr120, and when I tested them again, both the msvcr120 and ucrtbase versions set errno correctly. -Alex