Re: [PATCH 4/4] widl: Generate WinRT runtimeclass name constants.

[Jacek Caban]

On 29.01.2021 09:50, Rémi Bernon wrote:
> Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com>
> ---
>
> Note that MIDL generates a L"" string here, I wasn't sure if we can now
> use them everywhere, and generating the WCHAR array was the safest way.

Note that this will still not work on on-PE targets where selectany is 
not supported. This will cause multiple declarations when included from 
multiple object files. I would suggest to treat it like we do with 
wide-char defines in other headers, something like:

#if defined(_MSC_VER) || defined(__MINGW32__)
const DECLSPEC_SELECTANY WCHAR RuntimeClass_... = L"...";

#else

static const WCHAR RuntimeClas_... = {...};

#endif


This should take care of all platforms.


Thanks,

Jacek