Re: [v7 07/10] ddraw7/tests: Test SetColorKey() on cubemap surfaces.

[Henri Verbeet]

On 10 November 2015 at 14:10, Riccardo Bortolato <rikyz619(a)gmail.com> wrote:
> From: Stefan Dösinger <stefan(a)codeweavers.com>
>
> Signed-off-by: Riccardo Bortolato <rikyz619(a)gmail.com>
> I'd prefer it if Stefan would just send this in himself.
> +    D3DDEVICEDESC7 device_desc;
> ...
> +    BOOL cubemap_supported;
> ...
> +    hr = IDirect3DDevice7_GetCaps(device, &device_desc);
> +    ok(SUCCEEDED(hr), "Failed to get device caps, hr %#x.\n", hr);
> +    cubemap_supported = !!(device_desc.dpcTriCaps.dwTextureCaps & D3DPTEXTURECAPS_CUBEMAP);
> ...
> +    if (!cubemap_supported)
> +        goto cleanup;
> This seems a bit pointless if you're only going to use
> "cubemap_supported" once. I think there should be a skip() here.