Re: [PATCH 2/3] kernel32: Fix tick count calculation on Mac.

[Chip Davis]

November 26, 2019 10:40 PM, "Dmitry Timoshkov" <dmitry(a)baikal.ru> wrote:
> Chip Davis <cdavis(a)codeweavers.com> wrote:
> > +#ifdef HAVE_MACH_CONTINUOUS_TIME
> > + if (&mach_continuous_time != NULL)
> > + return mach_continuous_time() * timebase.numer / timebase.denom / 100;
> > +#endif
>
> While the compiler will fix it for you it would still be better to use
> 'if (mach_continuous_time != NULL)' IMO, so that even if the type of
> the 'mach_continuous_time' is a real function pointer it still works.
> Same applies to the next patch. That's a pure cosmetics though.

In the case that mach_continuous_time is linked strong, which it will be if -mmacosx-version-min=10.12 or higher, the compiler will warn if I *don't* use '&'.


Chip