I noticed that the tests I added for this patch failed to pass TestBot. This is my first patch so I may have missed something. I ran the test suite locally like this: WINETEST_DEBUG=1 ./wine ./dlls/msvcrt/tests/msvcrt_test.exe file When running the test suite with the Wine version that is included in Fedora 34, it fails as expected: file.c:123: Test failed: overwrote existing file with mode wx file.c:133: Test failed: overwrote existing file with mode w+x With my patch, my test cases passes locally but TestBot says: file.c:119: Test failed: creating file with mode wx failed file.c:129: Test failed: creating file with mode w+x failed Any advice? Best regards, Ted Lyngmo Den 2021-10-07 kl. 18:52, skrev Ted Lyngmo:
This fixes bug 51846: Standard library call fopen(..., "wx") not recognized - causes destruction of data.