On 29.03.2016 22:13, Bernhard Übelacker wrote:
https://bugs.winehq.org/show_bug.cgi?id=39734
This patch should avoid crash in acedrv11.sys. IoAllocateIrp is called with a stack_size of -128. Therefore ExAllocatePool gets a negative size value.
Tested against Windows XP. (See the test based on wine-staging "driver testing framework" attached to the bug.) ( https://newtestbot.winehq.org/JobDetails.pl?Key=21722 testrun by Sebastian Lackner.)
Try 1: https://www.winehq.org/pipermail/wine-patches/2016-March/148587.html Review 1: https://www.winehq.org/pipermail/wine-devel/2016-March/112476.html
Changes since try 1: - Fix usage of wrong variable. - Use a better name for variable. - Simplify if statement.
Signed-off-by: Bernhard Übelacker <bernhardu(a)vr-web.de> --- dlls/ntoskrnl.exe/ntoskrnl.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
Thanks for the updated version. Could you maybe also add a couple of additional tests with charge_quota = TRUE? Since you are changing both versions, I'm fearing a bit that your changes could break other situations. If there are no unexpected test failures it looks good to me.