Re: [PATCH] devenum: Do not fail with a IBindCtx (with tests)

[Dmitry Timoshkov]

Detlef Riekenberg <wine.dev(a)web.de> wrote:
> static HRESULT WINAPI DEVENUM_IMediaCatMoniker_BindToStorage(IMoniker *iface, IBindCtx *pbc,
>          IMoniker *pmkToLeft, REFIID riid, void **ppvObj)
>  {
> +    static IBindCtx *old_bc;
>      MediaCatMoniker *This = impl_from_IMoniker(iface);
>
> TRACE("(%p)->(%p, %p, %s, %p)\n", This, pbc, pmkToLeft, debugstr_guid(riid), ppvObj);
>
> *ppvObj = NULL;
>
> -    if (pbc || pmkToLeft)
> +    if (pbc != old_bc)
> +    {
> +        FIXME("ignoring IBindCtx %p\n", pbc);
> +        old_bc = pbc;
> +    }

This doesn't look sane.

-- 
Dmitry.