Re: [PATCH vkd3d v2 7/7] vkd3d: Handle plane slice for texture views.

[Henri Verbeet]

On Tue, 18 Jan 2022 at 06:08, Conor McCarthy <cmccarthy(a)codeweavers.com> wrote:
> @@ -2758,7 +2781,8 @@ void d3d12_desc_create_srv(struct d3d12_desc *descriptor,
>                  vkd3d_desc.layer_idx = desc->u.Texture2DArray.FirstArraySlice;
>                  vkd3d_desc.layer_count = desc->u.Texture2DArray.ArraySize;
>                  if (desc->u.Texture2DArray.PlaneSlice)
> -                    FIXME("Ignoring plane slice %u.\n", desc->u.Texture2DArray.PlaneSlice);
> +                    vkd3d_desc.vk_image_aspect = vk_image_aspect_flags_from_d3d12_plane_slice(resource->format,
> +                            desc->u.Texture2D.PlaneSlice);
> [...]
> @@ -2963,7 +2988,8 @@ static void vkd3d_create_texture_uav(struct d3d12_desc *descriptor,
>                  vkd3d_desc.layer_idx = desc->u.Texture2DArray.FirstArraySlice;
>                  vkd3d_desc.layer_count = desc->u.Texture2DArray.ArraySize;
>                  if (desc->u.Texture2DArray.PlaneSlice)
> -                    FIXME("Ignoring plane slice %u.\n", desc->u.Texture2DArray.PlaneSlice);
> +                    vkd3d_desc.vk_image_aspect = vk_image_aspect_flags_from_d3d12_plane_slice(resource->format,
> +                            desc->u.Texture2D.PlaneSlice);
> [...]
> @@ -3214,7 +3241,8 @@ void d3d12_rtv_desc_create_rtv(struct d3d12_rtv_desc *rtv_desc, struct d3d12_dev
>                  vkd3d_desc.layer_idx = desc->u.Texture2DArray.FirstArraySlice;
>                  vkd3d_desc.layer_count = desc->u.Texture2DArray.ArraySize;
>                  if (desc->u.Texture2DArray.PlaneSlice)
> -                    FIXME("Ignoring plane slice %u.\n", desc->u.Texture2DArray.PlaneSlice);
> +                    vkd3d_desc.vk_image_aspect = vk_image_aspect_flags_from_d3d12_plane_slice(resource->format,
> +                            desc->u.Texture2D.PlaneSlice);

Those should be using "desc->u.Texture2DArray.PlaneSlice" instead of
"desc->u.Texture2D.PlaneSlice".