Re: [PATCH vkd3d v2 1/6] vkd3d-shader/hlsl: Properly free parse_variable_def memory in declare_vars().

[Zebediah Figura (she/her)]

On 2/22/22 16:13, Francisco Casas wrote:
> Signed-off-by: Francisco Casas <fcasas(a)codeweavers.com>
> Signed-off-by: Giovanni Mascellani <gmascellani(a)codeweavers.com>
>
> ---
> v2:
> - Removed guards for vkd3d_free(v->arrays.sizes).
>
> Signed-off-by: Francisco Casas <fcasas(a)codeweavers.com>

This looks fine, although you could make things even easier by freeing 
v->arrays.sizes immediately after calling hlsl_new_var(); we don't 
actually need it later.