Re: [PATCH 3/3] winecfg: add speaker config controls to audio tab

[André Hentschel]

Hi,
first, this should be merged with patch 2. (atomic changes)

Am 26.01.2015 um 23:28 schrieb Mark Harmstone:
> -    IPropertyStore_Release(ps);
>      if(FAILED(hr)){
>          CoTaskMemFree(info->id);
>          info->id = NULL;
> +        IPropertyStore_Release(ps);
>          return FALSE;
>      }

This looks like a independent atomic fix...
> +    hr = IPropertyStore_GetValue(ps,
> +            &PKEY_AudioEndpoint_PhysicalSpeakers, &pv);
> +
> +    info->speaker_config = 999;
> +    if(SUCCEEDED(hr) && pv.vt == VT_UI4){

minor whitespace issue(s)
and seen some more whitespace issues, no need to keep consistent with existing code here i'd say
> +
> +    /* fallback to stereo */
> +    if(info->speaker_config == 999)

my thoughts on this: not sure, maybe -1 is better, or ~0. maybe it should be unsigned...

I hope my thoughts help anyway