4 Jul
2022
4 Jul
'22
7:59 a.m.
Huw Davies (@huw) commented about dlls/winepulse.drv/pulse.c:
fmt->dwChannelMask = pa_mask; }
-static void pulse_probe_settings(int render, WAVEFORMATEXTENSIBLE *fmt) { +static void pulse_probe_settings(int render, WAVEFORMATEXTENSIBLE *fmt, REFERENCE_TIME *def_period, REFERENCE_TIME *min_period, CHAR *pulse_name) {
If you end up using this in the next version, then please use something like: ```suggestion:-0+0 static void pulse_probe_settings(int render, const char *pulse_name, WAVEFORMATEXTENSIBLE *fmt, REFERENCE_TIME *def_period, REFERENCE_TIME *min_period) { ``` so that the [out] parameters are at the end and let's put that opening brace on a new line. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/337#note_3187