7 Sep
2019
7 Sep
'19
7:46 a.m.
Alex Henrie <alexhenrie24(a)gmail.com> writes:
I think that instead of making the buffer bigger, it would be better to add kernelbase to the IMPORTS line of dlls/advpack/tests/Makefile.in, include shlwapi.h in files.c, and then change lstrcatA to StrCatBuffA.
Arguably such buffer overflows in tests don't matter either way, but using a function that would silently truncate the path is not an improvement in general. -- Alexandre Julliard julliard(a)winehq.org