Re: [PATCH vkd3d 5/5] vkd3d-shader/hlsl: Separate an add_constructor() helper.

[Matteo Bruni]

On Tue, Sep 21, 2021 at 12:01 PM Giovanni Mascellani
<gmascellani(a)codeweavers.com> wrote:
> Signed-off-by: Giovanni Mascellani <gmascellani(a)codeweavers.com>
> --
> The other error branches in the bison rule are missing a
> "free_parse_initializer(&$4)", right? Maybe it's not this commit's
> scope, but still there seems to be a resource leak.

That seems right. There are probably more leaks (especially in error
cases), patches fixing them are certainly welcome.
> Thanks, Giovanni.