Re: [PATCH] msvcrt: Fix the layout of threadlocaleinfostruct for ucrt

[Piotr Caban]

Hi Martin,

On 10/2/19 9:32 AM, Martin Storsjo wrote:
> typedef struct MSVCRT_threadlocaleinfostruct {
> +#if _MSVCR_VER >= 140
> +    // In UCRT, only these three members are visible in user facing headers.
> +    unsigned short *pctype;
> +    int mb_cur_max;
> +    unsigned int lc_codepage;
> +    // Keep the rest of the struct (except for these members) below, that
> +    // msvcrt internal code needs.
> +#endif
> The change looks good for me. Please don't use c++ style comments 
> (probably the comments are not needed at all).

Thanks,
Piotr