Re: [PATCH 3/4] d3drm: Implement IDirect3DRM*_CreateTexture.

[Stefan Dösinger]

> Am 28.04.2016 um 20:17 schrieb Aaryaman Vasishta <jem456.vasishta(a)gmail.com>:
>
> @@ -198,13 +198,24 @@ static HRESULT WINAPI d3drm1_CreateTexture(IDirect3DRM *iface,
>     struct d3drm_texture *object;
>     HRESULT hr;
>
> -    FIXME("iface %p, image %p, texture %p partial stub.\n", iface, image, texture);
> +    TRACE("iface %p, image %p, texture %p.\n", iface, image, texture);
> +
> +    if (!d3drm_validate_image(image))
> +        return D3DRMERR_BADVALUE;
>
> if (FAILED(hr = d3drm_texture_create(&object)))
> +    {
> +        d3drm_texture_destroy(object);
>         return hr;
> +    }
> +    object->d3drm = iface;
> +    object->initialized = TRUE;
> +    object->image = image;
>
> *texture = &object->IDirect3DRMTexture_iface;
>
> +    IDirect3DRM_AddRef(iface);
> +
>     return D3DRM_OK;
> }

Is there anything wrong with calling Texture3::InitFromImage here, or even calling IDirect3DRM3::CreateTexture? in D3DRM1::CreateTexture and D3DRM2::CreateTexture?