Re: [PATCH v2 1/7] wmp: Add IWMPPlayer interface

[Anton Romanov]

Jacek,

On Tue, Feb 6, 2018 at 8:34 AM, Jacek Caban <jacek(a)codeweavers.com> wrote:
> Hi Anton,
>
> On 02/02/2018 07:00 AM, Anton Romanov wrote:
> > TRACE("(%p)->(IID_IWMPPlayer4 %p)\n", This, ppv);
> >          *ppv = &This->IWMPPlayer4_iface;
> > +    }else if(IsEqualGUID(riid, &IID_IWMPPlayer)) {
> > +        TRACE("(%p)->(IID_IWMPPlayer %p)\n", This, ppv);
> > +        *ppv = &This->IWMPPlayer4_iface;
>
> You can't do that. IWMPPlayer4 doesn't inherit from IWMPPlayer, so it's
> not the same interface. Also a short test (just calling QueryInterface()
> and checking the result) would be nice.

Thanks for feedback.
Have you had a chance to look at other patches in this series?
I'm just unsure should I address something else as well before
submitting new version.