Re: [PATCH v2] find: First simple implementation and tests

[Dmitry Timoshkov]

Fabian Maurer <dark.shadow4(a)web.de> wrote:
> diff --git a/configure b/configure
> index 337ce912fe..40f697d60c 100755
> --- a/configure
> +++ b/configure

Please avoid sending generated code, this unnecessarily bloats up size
of the patch, and also changes not related random lines.
> --- a/programs/find/Makefile.in
> +++ b/programs/find/Makefile.in
> @@ -1,4 +1,7 @@
>  MODULE    = find.exe
> -APPMODE   = -mconsole -municode
> +APPMODE   = -mconsole
> ...
> -int wmain(int argc, WCHAR *argv[])
> ...
> +int main(int argc, char *argv[])

Please keep the application unicode, otherwise it won't work for utf-8
input and not proper ANSI code page (like en_US.UTF-8 locale and cyrillic
string to find).

-- 
Dmitry.