Re: [PATCH] wined3d: Reuse deferred uploads heaps.

[Henri Verbeet]

On Fri, 25 Mar 2022 at 09:50, Jan Sikorski <jsikorski(a)codeweavers.com> wrote:
> @@ -4090,12 +4094,22 @@ static bool wined3d_deferred_context_map_upload_bo(struct wined3d_device_context
>              deferred->upload_count + 1, sizeof(*deferred->uploads)))
>          return false;
>
> -    if (!deferred->upload_heap)
> -        deferred->upload_heap = HeapCreate(HEAP_NO_SERIALIZE, 0, 0);
>      if (!deferred->upload_heap)
>      {
> -        ERR("Failed to create upload heap.\n");
> -        return false;
> +        if (!(deferred->upload_heap = HeapCreate(0, 0, 0)))
> +        {
> +            ERR("Failed to create upload heap.\n");
> +            return false;
> +        }
> +
> +        if (!(deferred->upload_heap_refcount = heap_alloc(sizeof(deferred->upload_heap_refcount))))
> +        {

It's probably not going to make a difference in practice, but
shouldn't that be "sizeof(*deferred->upload_heap_refcount)" above?