Re: [PATCH v2] iphlpapi: Add support for ConvertLengthToIpv4Mask()

[Henri Verbeet]

On 18 March 2018 at 17:34, Dagfinn Reiakvam <dagfinn(a)reiakvam.no> wrote:
> Yes, that looks more tidy. I was not aware of the htonl() function. Where in
> particular do you think the tests would benefit from this function?

E.g. here:
> +  apiReturn = pConvertLengthToIpv4Mask(1, &Mask);
> +  ok(apiReturn == NO_ERROR,
> +   "ConvertLengthToIpv4Mask returned %d, expected NO_ERROR\n", apiReturn);
> +  ok(Mask == 0x00000080,
> "ok(mask == htonl(0x80000000), ...);" would be both a little more
> obvious and more correct on big-endian systems if there still were
> any.