Re: [PATCH 02/14] mshtml: Actually set the return value when removing an attribute.

[Jacek Caban]

On 11/16/21 3:29 PM, Gabriel Ivăncescu wrote:
> -    if(dispex_compat_mode(&This->node.event_target.dispex) >= COMPAT_MODE_IE8)
> -        return element_remove_attribute(This, strAttributeName);
> +    if(dispex_compat_mode(&This->node.event_target.dispex) >= COMPAT_MODE_IE8) {
> +        *pfSuccess = element_has_attribute(This, strAttributeName);
> +        if(*pfSuccess == VARIANT_TRUE)

Please don't compare bools to a value, this could be simply:

if(*pfSuccess)


Thanks,

Jacek