Re: Fix for ddraw: CreateSurface

[Lionel Ulmer]

On Thu, May 29, 2003 at 12:12:26AM +0200, Sylvain Petreolle wrote:
> Since some surface types are unhandled for now, OffScreenPlain is
> assumed.
>
> Unused members of the DDSURFACEDESC2 structure are set to zero,
> so the bitperpixel is zero.
>
> DDRAW_width_bpp_to_pitch is called with bpp 0 and apps are stopping on
>
> assert(bpp != 0); /* keeps happening... */
>
> At least WinDVD starts with this patch, will it be accepted until we
> implement other surface types ?

Well, I think it would be better to check for the OVERLAY flag and return
'NOT SUPPORTED' in this case.

Could you try this and tell us if it works too ?

                     Lionel

PS: can't really send a patch as I am a bit far from my box :-)

-- 
		 Lionel Ulmer - http://www.bbrox.org/