April 8, 2022 8:34 AM, "Giovanni Mascellani" <gmascellani(a)codeweavers.com> wrote:
Signed-off-by: Giovanni Mascellani <gmascellani(a)codeweavers.com> --- That's fine for me, but you could have added if "src_count = 0" thing just before the "if" that writes the "else" (confusing, isn't it?), and it would have covered both branches.
Yes, but, just for the sake of discussing about trivialities, I prefer to keep instructions that are part of the same action close to each other. More so given that the code is our documentation. As I see it, there are 2 separate actions here: "Reuse the if instruction for making the else instruction" or "Reuse the if instruction for making the endif instruction". Granted that this inclination may introduce a little redundancy. Francisco.