Re: [PATCH 1/4] msvcp110: Add tr2_sys__File_size implementation and test.(try 3)

[YongHao Hu]

Hi, Piotr.
Thank you for your review. :)
Do you mean that I should not test GetLastError in msvcp?
I am afraid it is necessary to test it because the implementation may 
change it and I found some issues about error handling in kernel32 
functions like RemoveDirectoryA and CopyFileA etc.

Regards.

On 2015年06月10日 04:47, Piotr Caban wrote:
> On 06/09/15 18:49, YongHao Hu wrote:
> > try 3:
> >       Add errno and SetLastError test.
> > The series looks good for me.
>
> The GetLastError value seems to be inconsistent (it's best visible in 
> _Equivalent tests). I'm not sure why I've asked you about testing 
> GetLastError, I was probably thinking about errno. Anyway I don't 
> think it's useful to test it in future.
>
> Thanks,
> Piotr