On 15/6/29 下午5:55, Piotr Caban wrote:
On 06/27/15 19:50, YongHaoHu wrote:
+static file_type stat_set_error(int *err_code) +{ + file_type ret; + *err_code = ERROR_SUCCESS; + + switch(GetLastError()) { + case ERROR_FILE_NOT_FOUND: + case ERROR_BAD_NETPATH: + case ERROR_INVALID_NAME: + case ERROR_BAD_PATHNAME: + case ERROR_PATH_NOT_FOUND: + ret = file_not_found; + break; + case ERROR_BAD_DEV_TYPE: + ret = regular_file; + break; + default: + ret = status_unknown; Shouldn't err_code be set to GetLastError in default case? You end up setting it to ERROR_SUCCESS in every case except if path is NULL.
Yeah, you are right.
Why are you handling ERROR_BAD_DEV_TYPE error here?
I don't have special reason, just base on the test result on testbot.
+ TRACE("(%s %p)\n", debugstr_a(path), err_code); + DWORD attr; This will produce a compilation warning.
Got it. Thank you for your comment. :)