Hi Serge, On 7/10/20 9:17 PM, Serge Gautherie wrote:
static void test_lldiv(void) { - static lldiv_t* (CDECL *p_lldiv)(lldiv_t*,LONGLONG,LONGLONG) = (void*)lldiv; lldiv_t r;
- p_lldiv(&r, (LONGLONG)0x111 << 32 | 0x222, (LONGLONG)1 << 32); - ok(r.quot == 0x111, "quot = %s\n", wine_dbgstr_longlong(r.quot)); - ok(r.rem == 0x222, "rem = %s\n", wine_dbgstr_longlong(r.rem)); Please don't remove old test (the way how the function is called needs to be changed but the arguments can be preserved). + /* 64bit / 8bit = _60bit quotient_ */ This comment is not really needed, please remove it. + r = lldiv(0x69CF00120033E78A, 0x30); I'm not sure if it's still the case but we were avoiding LONGLONG constants for compatibility reasons. That's why the tests were using (ULONGLONG)0x... << 32 | 0x... to compute the values.
Thanks, Piotr