Re: [PATCH v2 1/5] msvcrt: Introduce IMPORT_SYMBOL helper macro.

[Chip Davis]

December 23, 2019 9:46 AM, "Jacek Caban" <jacek(a)codeweavers.com> wrote:
> diff --git a/dlls/msvcrt/msvcrt.h b/dlls/msvcrt/msvcrt.h
> index 2ac7977182..4ee94e8990 100644
> --- a/dlls/msvcrt/msvcrt.h
> +++ b/dlls/msvcrt/msvcrt.h
> @@ -62,6 +62,14 @@
>  #define MSVCRT__MAX_FNAME  256
>  #define MSVCRT__MAX_EXT    256
>
> +#if !defined(__MINGW32__)
> +#define IMPORT_SYMBOL(name)
> +#elif defined(__i386__)
> +#define IMPORT_SYMBOL(name) void *_imp_##name = name;

Doesn't this need an extra '_' after the "_imp_" in this case?
> +#else
> +#define IMPORT_SYMBOL(name) void *__imp_##name = name;
> +#endif
> +
>  typedef unsigned char  MSVCRT_bool;
>  typedef unsigned short MSVCRT_wchar_t;
>  typedef unsigned short MSVCRT_wint_t;

Chip